[Ffmpeg-devel] Re: Bethsoft VID demuxer and decoder

[Michael Niedermayer]

Hi

On Sat, Apr 07, 2007 at 07:57:31AM -0700, Nicholas T wrote:
> I disagree with pt 2. Other things changed, yes it is nitpicking. I
> hope you understand that I am new to ffmpeg's code, so I wrote now
> obvious comments so I could remember what library functions were
> doing.
> 
[...]
> +            yoffset = bytestream_get_le16(&buf);
> +            if(yoffset > avctx->height) { return -1; }

>=


> +            destination += vid->frame.linesize[0] * yoffset;
> +    }
> +
> +    // main code
> +    while((rle_num_bytes = *buf++))
> +    {
> +        length = rle_num_bytes & 0x7f;

int length = ...
avoids the int length; up there

[...]
> +    stream->codec->codec_tag = 0;

this is still unneeded


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070407/3dfb0abf/attachment.pgp>