[Ffmpeg-devel] [PATCH] CRYO APC demuxer

Anssi Hannula anssi.hannula
Sat Apr 7 19:01:18 CEST 2007


Anssi Hannula wrote:
> Hi!
> 
> Attached is a patch implementing a demuxer for CRYO APC, a simple audio
> format using ADPCM encoding.
> 
> Please review.

Attached is a patch updated as per Michael's and Reimar's comments.

I still av_free() st->codec and st on failure, though, as otherwise
there would be a memleak. Maybe av_free_stream() should be separated
from av_close_input_file() and have the demuxers call it when failure
occurs in read_header() after streams are allocated, or alternatively
have the av_open_input_stream() call it when read_header() returns with
an error. That belongs to a separate patch, though.

-- 
Anssi Hannula

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-apc_2.diff
Type: text/x-patch
Size: 5914 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070407/93cccb6c/attachment.bin>



More information about the ffmpeg-devel mailing list