[Ffmpeg-devel] [PATCH] DVR-MS probe audio format - was DVR-MS bug (MP2 decoding)

[John Donaghy]

>
> iam fine with either that is as long as it works, no seek no flush is of
> course nicer if it mostly works


Jon Elwood (who is working on DVRMSToolbox to make it use mencoder as the
default way of converting dvr-ms files) has extensively tested this patch
and discovered that it wasnt always possible to avoid a seek and flush
without sync issues.

He also discovered that the probe functions sometimes return 1 rather than a
value greater than 1 on the audio data I provide. (I would have expected
higher values in all cases.) So this version first tries to detect the audio
stream type by looking for a value > 1 and then, if that fails, it looks for
a probe result of '1' to determine the stream type. It works for all Jon's
samples.

I also had to do a url_fseek after the flush to avoid and output errors.

Let me know if all of this is acceptable.

Finally I removed the line that sets the format tag and consequently this
will not work with the lavf demuxer in mplayer. So I will attempt to fix
this and I'll raise a bug if I cant.

Thanks,

John

[...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> No snowflake in an avalanche ever feels responsible. -- Voltaire
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mp3_probe.patch
Type: application/octet-stream
Size: 497 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070408/4615e9fa/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: raw_probe.patch
Type: application/octet-stream
Size: 485 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070408/4615e9fa/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lavf_asf_ac3.diff
Type: text/x-patch
Size: 5555 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070408/4615e9fa/attachment.bin>