[Ffmpeg-devel] [PATCH] DVR-MS probe audio format - was DVR-MS bug (MP2 decoding)

[Michael Niedermayer]

Hi

On Mon, Apr 09, 2007 at 06:41:36PM -0500, John Donaghy wrote:
> >
> >
> >
> >well what will break if you remove the first check and just check at the
> >end?
> 
> 
> 
> Probably nothing but I can test to find out. I though it was better to get
> out as soon as possible because of the frame flush it has to do. If nothing
> breaks do you want me to re-submit with the check only at the end? 

yes


> Also is
> there a better way to set te ecodec_id than this:
> 
>        if (strncmp(fmt->name, "mp3", 3) == 0)
>            st->codec->codec_id = CODEC_ID_MP3;
>        else if (strncmp(fmt->name, "ac3", 3) == 0)
>            st->codec->codec_id = CODEC_ID_AC3;

i dunno ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070410/a924cec5/attachment.pgp>