[Ffmpeg-devel] [PATCH] TIFF encoder (Google SoC qualification task)

[Michael Niedermayer]

Hi

On Fri, Apr 06, 2007 at 11:05:59PM +0200, Kamil Nowosad wrote:
> Hi
> 
> On Fri, Apr 06, 2007 at 10:38:12PM +0200, Michael Niedermayer wrote:
> > >      if (s->compr == TIFF_DEFLATE || s->compr == TIFF_ADOBE_DEFLATE)
> > >          //best choose for DEFLATE
> > > -        s->rps = s->height;
> > > -    else
> > > +        s->rps = ((s->height - 1) / s->subsampling[1] + 1) * s->subsampling[1];
> > > +    else {
> > >          s->rps = FFMAX(8192 / (((s->width * s->bpp) >> 3) + 1), 1);     // suggest size of strip
> > > +        s->rps = ((s->rps - 1) / s->subsampling[1] + 1) * s->subsampling[1]; // round rps up
> > > +    }
> > 
> > hmm, doesnt the following work too?
> > 
> >     s->rps = s->height;
> > else
> >     s->rps = FFMAX(8192 / (((s->width * s->bpp) >> 3) + 1), 1);     // suggest size of strip
> > s->rps = ((s->rps - 1) / s->subsampling[1] + 1) * s->subsampling[1]; // round rps up
> > 
> 
> huh, of course...
> i should have read the code once more... ;-)
[...]
>      }
> +    if (!is_yuv)
>      s->bpp_tab_size = (s->bpp >> 3);
[...]
> +            else
>              memcpy(zbuf + j * bytes_per_row,
>                     p->data[0] + j * p->linesize[0], bytes_per_row);
>              zn += bytes_per_row;

iam still waiting for a patch which fixes the indention after this ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070410/1bb35dc0/attachment.pgp>