[Ffmpeg-devel] Re: [PATCH] fix ffmpeg is killed for some img convert

[Michael Niedermayer]

Hi

On Thu, Apr 12, 2007 at 02:39:12PM +0200, Michel Bardiaux wrote:
> Michael Niedermayer wrote:
> >Hi
> >
> >On Thu, Apr 12, 2007 at 05:52:45PM +0800, Limin Wang wrote:
> >>Hi,
> >>
> >>>Hi,
> >>>
> >>>Update the patch to fix the dead loop recursive function issue, I have 
> >>>pass
> >>>simple test for these be killed image conversion and "make test", please
> >>>review it.
> >>Any comments? The bug can be reproduced by yuv420p -> bgr32 etc.
> >
> >well, the old imgconvert/resample code is deprecated and unmaintained
> 
> img_convert is needed if you want LGPL. So you cant declare it 
> deprecated and unmaintained. 

last time i checked you where not my employer so you cant decide what i 
maintain and what i do not maintain
also i dont care about LGPL, thouse who do can maintain the code
or work on getting swscale under LGPL, which was almost done when walken
claimed rights on the yuv2rgb reimplementation and scared the author of
the code away by that ...


> In avcodec.h the 'attribute deprecated' for 
> img_convert should at least be under #ifndef CONFIG_SWSCALER

NO, RTFS!
the img_convert code can be used over the swscale API if swscale is
disabled, the old img_convert API WILL be removed with the next version
bump

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070412/6a25f310/attachment.pgp>