[Ffmpeg-devel] [PATCH] Fixed configure bug; can now compile on x86_32 with --enable-gprof option

[Jason Garrett-Glaser]

The EBP test calls check_exec:

check_exec()
{
    check_ld "$@" && { enabled cross_compile || $TMPE >>$logfile 2>&1; }
}

which calls

check_ld(){
    log check_ld "$@"
    check_cc || return
    check_cmd $cc $LDFLAGS "$@" -o $TMPE $TMPO $extralibs
}

At this point -p is not added because

if enabled gprof; then
    add_cflags  "-p"
    add_ldflags "-p"
fi

has not been run.

I tried to move the gprof check up, but it breaks a whole ton of other
checks when I do so.

The only thing I can think of is a kludgy hack that would add -p (if
gprof is enabled) before the EBP/EBX check function and back up the
previous CFLAGS/LDFLAGS in two temporary variables, then restore the
backups, then restore them after the check.  It works fine, and I
can't think of many other possibilities, but it seems kludgy.  I have
attached this as a patch, though I don't know whether it would be
reasonable to actually commit it to the SVN.

Dark Shikari

On 4/13/07, Michael Niedermayer <michaelni at gmx.at> wrote:
> Hi
>
> On Fri, Apr 13, 2007 at 08:14:32AM -0400, Jason Garrett-Glaser wrote:
> > I found the problem that caused CONFIG_7REG to be enabled even if on
> > an 8-register processor when --enable-gprof was enabled, which
> > requires the EBP register.  The configure script simply didn't take
> > this into account, and enabled profiling without disabling the use of
> > EBP.
> >
> > This has been fixed in the attached patch, a diff -up file.
> >
> > This is my first patch for FFMPEG so tell me if I did anything wrong.
>
> the patch looks reversed, also its mime type is application/octet-stream
>
> now to the content of the patch
> if the ebp check says ebp is available with profiling on then either
> the check is buggy and should be fixed or ebp is available and the
> bug is elseswhere
>
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Those who are too smart to engage in politics are punished by being
> governed by those who are dumber. -- Plato
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: application/octet-stream
Size: 686 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070413/17882c48/attachment.obj>