[Ffmpeg-devel] [PATCH] mjpeg cleanup and again interlaced fix
Baptiste Coudurier
baptiste.coudurier
Sat Apr 14 18:36:25 CEST 2007
Michael Niedermayer wrote:
> Hi
>
> On Sat, Apr 14, 2007 at 02:36:07PM +0200, Baptiste Coudurier wrote:
> [...]
>>> [...]
>>>>> i think you know what you patch does and why and its not unreasonable to
>>>>> expect you to explain this to me instead of asking me to go over a few 100
>>>>> pages of manuals ...
>>>> Of course I know, but Im quite exhausted feeling no trust whatsoever and
>>>> always nitpicking, and I think Im not the only one developer feeling
>>>> that.
>>> i think steve lhomme feels similarely, at least he did in the past maybe
>>> you want to fork ffmpeg together with him
>>> here code must pass review to reach svn, no matter how much
>>> the author complains and feel unfairly treated, even if its true and he
>>> is unfairly treated which i dont think so, just look at the SOC students
>>> as example, they have resubmitted their patches many many times and didnt
>>> complain, you submit the code once, pester me if i dont review it, ask me
>>> to read a large manual instead of awnsering a question and you didnt
>>> resubmit the patch without cosmetics at all
>> And I think you really bad treated those SoC students, requesting for a
>> simple cosmetic patch after you applied the patch, while you could do it
>> yourself is clearly abusing. Laziness have become the main characteric
>> around here.
>
> why didnt you fix the indention after the students if you belive that its
> not their job? also i said clearly on svn log that ill fix the indention if
> the student doesnt. and i think ive done enough work reviewing their patches
> often with only half or less of the comments taken care of
>
> furthermore as you surely are aware i did very significant cleanup work
> on the students code after it was commited, i dont remember a single commit
> from you cleaning up any students code nor do i remember you reviewing much
Also I think you should not be maintainer if you are not inclined to fix
bugs in code you maintain. Fixing bugs should be a PRIORITY.
--
Baptiste COUDURIER GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A. http://www.smartjog.com
Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312
More information about the ffmpeg-devel
mailing list