[Ffmpeg-devel] [PATCH] TTA Seeking
David Conrad
umovimus
Sat Apr 14 18:47:50 CEST 2007
On Apr 14, 2007, at 7:53 AM, Michael Niedermayer wrote:
> Hi
>
> On Fri, Apr 13, 2007 at 10:33:27PM -0400, David Conrad wrote:
>> Hi,
>>
>> The following patch adds support for seeking in TTA files.
>
> [...]
>
>> + av_add_index_entry(st, framepos, i*framelen, size, 0,
>> AVINDEX_KEYFRAME);
>
> it looks like your patch has been mangled
Our of curiosity, is inlining patches preferred? Luca Barbato
requested that I inline my patches last time.
>> + framepos += size;
>> + }
>> url_fskip(&s->pb, 4); // seektable crc
>> - st = av_new_stream(s, 0);
>> -// av_set_pts_info(st, 32, 1, 1000);
>
>> if (!st)
>> return AVERROR_NOMEM;
>
> this check should be moved up it has no sense here, things will
> segfault
> if its true ...
You're right, I completely missed this check.
-David
More information about the ffmpeg-devel
mailing list