[Ffmpeg-devel] [PATCH] TTA Seeking

[Aurelien Jacobs]

On Sat, 14 Apr 2007 12:49:12 -0400
David Conrad <umovimus at gmail.com> wrote:

> On Apr 14, 2007, at 11:30 AM, Michael Niedermayer wrote:
> 
> > Hi
> >
> > On Sat, Apr 14, 2007 at 04:44:30PM +0200, Aurelien Jacobs wrote:
> >> On Fri, 13 Apr 2007 22:33:27 -0400
> >> David Conrad <umovimus at gmail.com> wrote:
> >>
> >>> Hi,
> >>>
> >>> The following patch adds support for seeking in TTA files.
> >>>
> >>> -David
> >>>
> >>> [...]
> >>>
> >>> -static int tta_read_close(AVFormatContext *s)
> >>> +static int tta_read_seek(AVFormatContext *s, int stream_index,
> >>> int64_t timestamp, int flags)
> >>>
> >>> [...]
> >>>
> >>> @@ -143,6 +140,7 @@
> >>>       tta_probe,
> >>>       tta_read_header,
> >>>       tta_read_packet,
> >>> -    tta_read_close,
> >>> +    NULL,
> >>
> >> Removal of tta_read_close is not related to this patch. Thus it  
> >> should
> >> go in a separate patch.
> >
> > tta_read_close() freed seektable, now seektable is no longer needed  
> > as the
> > lavf index code is used
> >
> > i agree that switching from seektable to the internal index code could
> > be a seperate patch from adding seeking support though IMHO i wouldnt
> > call them unrelated
> 
> New patch that only changes from using the seektable to the lavf  
> index code attached. Also correctly moves the !st check.

Patch looks fine to me (except for the mime type of the attachement ;-)

Aurel