[Ffmpeg-devel] [PATCH] fix CONFIG_EBX_AVAILABLE on Darwin/x86

[Alexander Strange]

On Apr 14, 2007, at 4:42 AM, Diego Biurrun wrote:

> On Fri, Apr 13, 2007 at 05:24:55PM -0400, Alexander Strange wrote:
>> The configure test is failing at the moment because it's run before
>> Darwin's PIC options are added to cflags.
>
> More details please.

 From config.err:
check_cc
BEGIN /tmp/ffmpeg-conf-3225-7537-24649.c
      1	int main(){
      2	    asm volatile ("":::"%ebx");
      3	}
END /tmp/ffmpeg-conf-3225-7537-24649.c
gcc -no-cpp-precomp -pipe -force_cpusubtype_ALL -Wno-sign-compare - 
fomit-frame-pointer -c -o /tmp/ffmpeg-conf-2571-7537-8647.o /tmp/ 
ffmpeg-conf-3225-7537-24649.c
/tmp/ffmpeg-conf-3225-7537-24649.c: In function 'main':
/tmp/ffmpeg-conf-3225-7537-24649.c:2: error: PIC register '%ebx'  
clobbered in 'asm'

-mdynamic-no-pic has to be enabled for the test to succeed, but its  
test comes after ebx_available.


>> It needs to be run after the -mdynamic-no-pic check, and VHOOKCFLAGS
>> needs to be set before that. This patch moves them to what I think
>> are better places, after which the test runs properly.
>
> They aren't better places, VHOOKCFLAGS is supposed to pick up *all*
> CFLAGS except for -mdynamic-no-pic.
>
> Diego

Alright, how's this? My sh isn't so good, so this might not be the  
right way to go about it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-configure-darwinebx-2.diff
Type: application/octet-stream
Size: 634 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070414/d23fd1d8/attachment.obj>