[Ffmpeg-devel] [PATCH] remove drop timecode flag

[Michael Niedermayer]

Hi

On Sun, Apr 15, 2007 at 08:27:55AM -0700, Trent Piepho wrote:
> On Sun, 15 Apr 2007, Michael Niedermayer wrote:
> >
> > attached patch removes the drop timecode encoding support
> > reasoning is that iam not aware of any use (not even obscure) of this feature
> 
> Isn't the timecode wrong if you don't use drop frame timecode for NTSC?
> 
> e.g., the timecode after exactly 1 hour of NTSC video will be
> '00:59:56:12', which is short 3 seconds and 18 frames from one hour.  With
> drop frame timecode, the timecode after an hour would be '01:00:00:00',
> since 108 timecodes would have been skipped over.

timecodes are codec specific
if a codec uses the rounded up fps as timebase then the timecode must be
scaled accordingly and if needed the drop flag be set, its not the user
applications job to do this

also the drop frame flag=1 is only allowed for 30000/1001 fps (per mpeg2 spec)
for 24000/1001 for example you need a different solution anyway so the
question is why not use that solution too for 30000/1001?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070415/00d3a8fb/attachment.pgp>