[Ffmpeg-devel] Third Try: Set bit_rate for asf format

[Zuxy Meng]

Hi,

2007/4/16, Michael Niedermayer <michaelni at gmx.at>:
> Hi
>
> On Mon, Apr 16, 2007 at 09:27:11AM +0800, Zuxy Meng wrote:
> > Hi,
> >
> > bitrate[i] is 0 because asf files used in the regression tests don't
> > contain a bitrate object. IMHO the encoder should guanrantee that the
> > bitrate in the wave header and the one in the object (if present) be
> > the same.
> >
> > Is codec->bit_rate always initialized to zero? If so we can use
>
> i think so
>
>
> > if (codec->bit_rate)
> > so bitrate in the bitrate object won't overwrite the wave header info.
>
> this looks better

Of course I meant if (!codec->bit_rate). Anyway the updated patch
attached (fulltest passed) and hopefully this is the final one.

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: asf.c.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070417/97a3c3ee/attachment.txt>