[Ffmpeg-devel] Changing "-vstats" option behaviour

[Michael Niedermayer]

Hi

On Tue, Apr 17, 2007 at 04:25:13PM +0200, Stefano Sabatini wrote:
> Hi.
> 
> On date Tuesday 2007-04-17 14:34:55 +0200, Michael Niedermayer encoded:
> > Hi
> > 
> > On Tue, Apr 17, 2007 at 11:41:57AM +0200, Stefano Sabatini wrote:
> > [...]
> > > I changed the -vstats option name to -vstats_file, that seems clearer
> > > and, being different from the previous option name, should also get
> > > the change more apparent to the user that was used to the previous
> > > behaviour.
> > > 
> > > I also changed the name of the function do_video_stats to do_vstats,
> > > which seems to me more consistent with the rest of the code.
> > 
> > renamings are cosmetic changes and MUST be seperate from functional changes
> 
> I consider the modification of the option name (-vstats -->
> -vstats_file) part of the "functional" change which changes the option
> meaning and the behaviour of the program, the new option name
> reflecting that change.

the externally vissible options are functional yes, the variable names are
not, renaming them is fine if it makes sense but in a seperate patch


[...]
>      if (enc->codec_type == CODEC_TYPE_VIDEO) {
>          frame_number = ost->frame_number;
> -        fprintf(fvstats, "frame= %5d q= %2.1f ", frame_number, enc->coded_frame->quality/(float)FF_QP2LAMBDA);
> +        fprintf(vstats_file, "frame= %5d q= %2.1f ", frame_number, enc->coded_frame->quality/(float)FF_QP2LAMBDA);

cosmetic


[...]

> @@ -3449,6 +3432,15 @@
>      }
>  }
>  
> +static void opt_vstats_file (const char *arg)
> +{
> +    vstats_file = fopen(arg ,"w");
> +    if (!vstats_file) {
> +	perror("fopen");
> +	exit(1);
> +    }

tabs are forbidden in svn



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070417/126f8cfb/attachment.pgp>