[Ffmpeg-devel] PATCH Blackfin UNALIGNED_STORES_ARE_BAD in bitstream.h

[Rich Felker]

On Tue, Apr 17, 2007 at 05:39:35PM +0200, Michael Niedermayer wrote:
> > Index: bitstream.h
> > ===================================================================
> > --- bitstream.h	(revision 8596)
> > +++ bitstream.h	(working copy)
> > @@ -166,7 +166,7 @@
> >      uint8_t run;
> >  } RL_VLC_ELEM;
> >  
> > -#if defined(ARCH_SPARC) || defined(ARCH_ARMV4L) || defined(ARCH_MIPS)
> > +#if defined(ARCH_SPARC) || defined(ARCH_ARMV4L) || defined(ARCH_MIPS) || defined(ARCH_BFIN)
> >  #define UNALIGNED_STORES_ARE_BAD
> 
> looks ok

IMO we should turn this the other way around:

#if !defined(ARCH_X86) && !defined(...)

Then the code will ALWAYS work, and just be suboptimal on archs we
haven't identified yet, rather than crashing on unknown archs.

Rich