[Ffmpeg-devel] Changing "-vstats" option behaviour

[Michael Niedermayer]

Hi

On Tue, Apr 17, 2007 at 06:45:19PM +0200, Stefano Sabatini wrote:
> On date Tuesday 2007-04-17 17:28:50 +0200, Michael Niedermayer encoded:
> > the externally vissible options are functional yes, the variable names are
> > not, renaming them is fine if it makes sense but in a seperate patch
> > 
> > 
> > [...]
> > >      if (enc->codec_type == CODEC_TYPE_VIDEO) {
> > >          frame_number = ost->frame_number;
> > > -        fprintf(fvstats, "frame= %5d q= %2.1f ", frame_number, enc->coded_frame->quality/(float)FF_QP2LAMBDA);
> > > +        fprintf(vstats_file, "frame= %5d q= %2.1f ", frame_number, enc->coded_frame->quality/(float)FF_QP2LAMBDA);
> > 
> > cosmetic
> > 
> > 
> > [...]
> > 
> > > @@ -3449,6 +3432,15 @@
> > >      }
> > >  }
> > >  
> > > +static void opt_vstats_file (const char *arg)
> > > +{
> > > +    vstats_file = fopen(arg ,"w");
> > > +    if (!vstats_file) {
> > > +	perror("fopen");
> > > +	exit(1);
> > > +    }
> > 
> > tabs are forbidden in svn
> 
> Hope this is OK.

iam fine with the patch assuming it passes regression tests and there
are no objections from other developers about the change of the command
line option

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070417/e1fb2823/attachment.pgp>