[Ffmpeg-devel] Changing "-vstats" option behaviour

[Michael Niedermayer]

Hi

On Thu, Apr 19, 2007 at 06:47:44PM +0200, Stefano Sabatini wrote:
[...]

> @@ -841,22 +841,15 @@
>  static void do_video_stats(AVFormatContext *os, AVOutputStream *ost,
>                             int frame_size)
>  {
> -    static FILE *fvstats=NULL;
[...]
> +    static FILE* fvstats=NULL;

cosmetic


[...]
> @@ -3449,6 +3442,29 @@
>      }
>  }
>  
> +static void opt_vstats_file (const char *arg)
> +{
> +    /* if the vstats_filename global has been already defined */
> +    if (vstats_filename) {
> +        fprintf (stderr, "Warning: redefining the already defined vstats file from \"%s\" to \"%s\"\n",
> +                vstats_filename, arg);
> +        av_free (vstats_filename);
> +    }

i think the warning is a overkill,  i think its inconsistant, other
options dont print such warnings either ...

and the av_free() doesnt need the if()


> +
> +    vstats_filename=av_strdup (arg);
> +}
> +
> +static void opt_vstats (void)
> +{
> +    char filename[40];
> +    time_t today2 = time(NULL);
> +    struct tm *today = localtime(&today2);
> +    

trailing whitespace


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070419/a982bd18/attachment.pgp>