[Ffmpeg-devel] Changing "-vstats" option behaviour

[Benoit Fouet]

Hi,

Stefano Sabatini wrote:
> On date Thursday 2007-04-19 18:03:55 +0200, Benoit Fouet encoded:
>   
>> Hi,
>>
>> Stefano Sabatini wrote:
>>     
>>> Index: ffmpeg.c
>>> ===================================================================
>>> --- ffmpeg.c	(revision 8759)
>>> +++ ffmpeg.c	(working copy)
>>> @@ -166,7 +166,6 @@
>>>  static int do_hex_dump = 0;
>>>  static int do_pkt_dump = 0;
>>>  static int do_psnr = 0;
>>> -static int do_vstats = 0;
>>>  static int do_pass = 0;
>>>  static char *pass_logfilename = NULL;
>>>  static int audio_stream_copy = 0;
>>> @@ -177,6 +176,7 @@
>>>  static int copy_ts= 0;
>>>  static int opt_shortest = 0; //
>>>  static int video_global_header = 0;
>>> +static char* vstats_filename=NULL;
>>>  
>>>   
>>>       
>> initialisation is unneeded, and i don't know about "coding rules" in
>> FFmpeg, but i personnaly prefer:
>> static char *vstats_filename;
>>     
>
> I preferred the previous one because there are other data initialized
> in the code, so I'm keeping the initialized version.
>
>   
i just thought new global variable use cases should not use this
unneeded initialization...
the second remark was about the position of the "*"

Ben