[Ffmpeg-devel] Changing "-vstats" option behaviour

[Benoit Fouet]

Stefano Sabatini wrote:
> On date Friday 2007-04-20 12:36:34 +0200, Benoit Fouet encoded:
>   
>> Hi,
>>
>> Stefano Sabatini wrote:
>>     
>>> Index: ffmpeg.c
>>> ===================================================================
>>> --- ffmpeg.c	(revision 8759)
>>> +++ ffmpeg.c	(working copy)
>>> @@ -3806,6 +3817,11 @@
>>>  
>>>      av_free(intra_matrix);
>>>      av_free(inter_matrix);
>>> +
>>> +    if (vstats_filename) {
>>> +        fclose(fvstats);
>>> +        av_free(vstats_filename);
>>> +    }
>>>   
>>>       
>> how about:
>> if (fvstats)
>>     fclose(fvstats);
>> av_free(vstats_filename);
>>     
>
> I prefer the former for a... psychology reason, enclosing it in a
> block make more apparent the correlation between the fvstats and
> vstats_filename object...
but you can also have vstats_filename set without fvstats being opened.
if do_video_stats function is not called (for a reason i don't (want to)
know), the filename exists even though the file is not opened, no ?

>   but isn't really important, so I let the
> choice to the maintainers.
>   
indeed.

Ben

-- 
Purple Labs S.A.
www.purplelabs.com