[Ffmpeg-devel] PATCH Blackfin optimized byte swapping mechanism

Diego Biurrun diego
Tue Apr 24 07:58:40 CEST 2007


On Mon, Apr 23, 2007 at 09:46:09PM -0400, Marc Hoffman wrote:
Content-Description: message body text
> Michael Niedermayer writes:
>  > 
>  > not everyone duplicated these 2 bswap functions, ARCH_ARM does not for
>  > example
>  > 
>  > also, just because the code in svn is a mess does not mean its ok to add
>  > more mess
>  > 
>  > and, iam rejecting patches which are messy mostly independant upon how
>  > difficult it is to implement a clean solution, so if it would require
>  > rewriting bswap.h then so be it but its not needed here, simply doing
>  > what ARCH_ARM does should work even if its not beautifull ...
>  > 
>  > if you want to cleanup bswap.h that is certainly welcome too, maybe
>  > a bswap.h which contains just the c functions under #ifndef FOOBAR16/32/64
>  > and then a bswap_arm.h, ...
> 
> I see your point and it makes good sense and is a much simpler patch

Patches from the root of the source tree please.  Commit log message
suggestions also appreciated.

Diego




More information about the ffmpeg-devel mailing list