[Ffmpeg-devel] Possible bug in reading PTS/DTS

[Baptiste Coudurier]

Hi

Michael Niedermayer wrote:
> Hi
> 
> On Mon, Apr 23, 2007 at 12:58:42PM +0200, Luca Abeni wrote:
>> Hi Michael,
>>
>> Michael Niedermayer wrote:
>>> Hi
>>>
>>> On Mon, Apr 23, 2007 at 09:58:26AM +0200, Luca Abeni wrote:
>>>> Hi all,
>>>>
>>>> I found a "strange feature" in ffmpeg. Basically, in some cases video 
>>>> PTSs and DTSs read from a stream have a strange offset respect to audio 
>>>> timestamps (I noticed this problem when trying to debug a strange 
>>>> ffserver behaviour, but the problem appears in ffmpeg.c too).
>>> does reverting r8465 fix this?
>> Yes, you are right. I reverted it by applying the attached patch (I 
>> attach it just to be sure that I did not revert the wrong thing), and 
>> everything works fine now.
>>
>>> if yes you have my approvial to revert this in svn
>> Ok good. Can I revert it by simply applying the attached patch (with a 
>> chagelog explaining why this has been reverted),
> 
> yes
> 
> 
>> or should I use some 
>> "svn cp" magic? (since there are other commits on utils.c after 8465, I 
>> am not sure if "svn cp" can work)
>>
>> BTW, has the error addressed by r8465 been fixed in some other way, or 
>> will it be re-introduced by reverting the commit (I do not want the 
>> responsibility of reintroducing a fixed bug :)?
> 
> i think it will reintroduce the issue, but i think the current behavior is
> significantly worse then how it was before ...
> 
> 
>>
>> I'll wait 1 day or 2, to give Wolfram the possibility to comment on 
>> this, then I'll apply the patch.
> 
> ok
> 

Good, Luca, will you revert it ? Else I'll do it.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312