[Ffmpeg-devel] [PATCH] avoid calling a NULL function in swscale.c

[Benoit Fouet]

Hi,

Michael Niedermayer wrote:
> Hi
>
> On Thu, Apr 26, 2007 at 11:29:22AM +0200, Benoit Fouet wrote:
>   
>> Hi,
>>
>> patch 1: add a test on conversion function prior to try to apply it
>>     
>
> and what is this good for? producing wrong output which is hard to debug
> instead of segfault which is easy to find the cause of?
>
>
>   
there's already a message:
av_log(c, AV_LOG_ERROR, "swScaler: internal error %s -> %s converter\n",
                 sws_format_name(srcFormat), sws_format_name(dstFormat));

isn't it enough ?

Ben

-- 
Purple Labs S.A.
www.purplelabs.com