[Ffmpeg-devel] [RFC PATCH] Selectable protocols

[Diego Biurrun]

On Thu, Apr 26, 2007 at 05:31:57PM +0200, Alex Beregszaszi wrote:
> 
> Attached is a patch which adds support for selectable protocols, using
> the same method as used by muxers/demuxers/parsers/etc.

Patch is very much welcome.

> If noone is opposing this, I will commit this in a few hours.

A few hours is much too short.  Always wait at least a day.

> --- configure	(revision 8829)
> +++ configure	(working copy)
> @@ -715,9 +717,13 @@
>  
> +udp_protocol_deps="network"
> +rtp_protocol_deps="network"
> +tcp_protocol_deps="network"
> +http_protocol_deps="network"

alphabetical order please

> -ffserver_deps="network protocols muxers"
> -network_deps="protocols"
> +ffserver_deps="network muxers"
 
Redundant dependency for ffserver extracted and committed, removing
network dependencies looks wrong.

> --- libavformat/allformats.c	(revision 8829)
> +++ libavformat/allformats.c	(working copy)
> @@ -162,15 +164,10 @@
>  
> +    REGISTER_PROTOCOL(FILE, file);
> +    REGISTER_PROTOCOL(PIPE, pipe);
> +    REGISTER_PROTOCOL(UDP, udp);
> +    REGISTER_PROTOCOL(RTP, rtp);
> +    REGISTER_PROTOCOL(TCP, tcp);
> +    REGISTER_PROTOCOL(HTTP, http);

alphabetical order please and align the second column

Please always use alphabetical order, it makes things more readable.

Diego