[Ffmpeg-devel] [PATCH] (try 2) Build shared libraries on AMD64 again

[Diego Biurrun]

On Wed, Apr 18, 2007 at 01:21:38PM +0200, Michael Niedermayer wrote:
> 
> On Wed, Apr 18, 2007 at 11:26:12AM +0200, Diego 'Flameeyes' Petten? wrote:
> > Maybe the patch was being lost in the discussion about why AMD64
> > requires PIC-compatible code, but as I still can't build PIC code from
> > FFmpeg, I'm sending the only working patch again.
> > 
> > It does not regress compared with the last building version before the
> > CONFIG_7REGS change: it was disabled before and it is again, as the
> > code is not PIC-compatible, and making it PIC compatible is going to
> > lose performance (beside the fact I have no clue where to start to make
> > it compatible).
> 
> iam fine with the patch though it would be better to
> 
> #if defined(ARCH_X86_64) && defined(PIC)
> #define BROKEN_RELOCATIONS 1
> 
> and
> 
> #if defined(ARCH_X86) && defined(CONFIG_7REGS) && !defined(BROKEN_RELOCATIONS)

Applied along with the suggestion.

Diego