[Ffmpeg-devel] [PATCH] FAAC profile selection

[Michael Niedermayer]

Hi

On Fri, Apr 27, 2007 at 08:11:54PM +0200, Nicolas George wrote:
> Hi.
> 
> Ten days ago, someone (Tim Small) posted on ffmpeg-user to point that the
> faac encoder was hard-coded to the low-complexity profile, and asking about
> the best way to make it an option. I suggested to use the -profile option.
> Since then, nothing.
> 
> Here is a patch (against a few minutes ago SVN) to do just that:
> 
> ffmpeg -i foo.flac -aq 100 -profile aac_ltp /tmp/ltp.aac
> 
> will encode in LTP profile.
> 
> The patch has two independent parts.
> 
> The part that changes faac.c is the one that do the work. It is absolutely
> trivial, and certainly harmless.
> 
> The second part makes the constants aac_main, aac_low, aac_ssr and aac_ltp
> known to ffmpeg. It requires #ifdefs and including faac.h, which is not very
> namespace-friendly, so it require more thought. But it is not required,
> -profile 3 would work just as well without it.

first patch ok

second patch not, the values used in AVOption should not be at the mercy of an
external header that is xyz_profile should have the same value independant of
what is in an external header or even if the external header is available at
all IMHO

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070427/2bcd586f/attachment.pgp>