[Ffmpeg-devel] Third Try: Set bit_rate for asf format

[Michael Niedermayer]

Hi

On Sat, Apr 28, 2007 at 10:49:47AM +0800, Zuxy Meng wrote:
> Hi,
> 
> 2007/4/17, Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > Hello,
> > On Tue, Apr 17, 2007 at 07:59:24PM +0800, Zuxy Meng wrote:
> > > @@ -504,11 +509,14 @@
> > >
> > >      for(i=0; i<128; i++){
> > >          int stream_num= asf->asfid2avid[i];
> > > -        if(stream_num>=0 && dar[i].num>0 && dar[i].den>0){
> > > +        if(stream_num>=0){
> > >              AVCodecContext *codec= s->streams[stream_num]->codec;
> > > -            av_reduce(&codec->sample_aspect_ratio.num,
> > > -                    &codec->sample_aspect_ratio.den,
> > > -                    dar[i].num, dar[i].den, INT_MAX);
> > > +            if (!codec->bit_rate)
> > > +                codec->bit_rate = bitrate[i];
> > > +            if (dar[i].num > 0 && dar[i].den > 0)
> > > +                av_reduce(&codec->sample_aspect_ratio.num,
> > > +                        &codec->sample_aspect_ratio.den,
> > > +                        dar[i].num, dar[i].den, INT_MAX);
> >
> > Hmm... you only change the indentation for that av_reduce? That should
> > be done in a separate step I think.
> 
> No other comments apart from this? I'm still waiting for Michael's....

i agree with reimar that the indention change should be seperate
except that iam fine with the patch

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070428/9d0648af/attachment.pgp>