[Ffmpeg-devel] [patch] h264.c, dont go beyond buffer in h264_decode_nal_unit

[Michael Niedermayer]

Hi

On Sun, Apr 29, 2007 at 11:32:59AM +0200, Mean wrote:
[...]
> >   
> >> +        if(buf_index +h->nal_length_size>= buf_size) 
> >> +        {
> >>     
> >
> > { placement missmatches the rest of the file
> > also this check is unneeded the buffer is a few bytes larger
> > and nal_length_size is limited to 2 or 4
> >
> >
> >   
>     I'm under the impression that buf_size in most cases is given by the 
> user application alongside the buffer itself.
>     It is likely to hold a few bytes more, but how can one be sure ?

see FF_INPUT_BUFFER_PADDING_SIZE


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070429/97edf055/attachment.pgp>