[FFmpeg-devel] MP2 file tagged with MP3

[Baptiste Coudurier]

Hi

Michael Niedermayer wrote:
> Hi
> 
> On Sat, Aug 04, 2007 at 12:37:29AM +0200, Baptiste Coudurier wrote:
>> Hi
>>
>> Michael Niedermayer wrote:
>>> Hi
>>>
>>> On Fri, Aug 03, 2007 at 07:07:15PM +0200, herve.flores wrote:
>>>> Hi,
>>>> since r9102, ffmpeg write headers of mp2 files with mp3 tags
>>>> related threads
>>>>
>>>> [...]
>>>>
>>> no patch -> wrong mailinglist 
>>> and before you waste more time find a solid proof that this is not a valid
>>> mp2 file
>>> solid are
>>> * refering to the mpeg audio spec
>>> * showing that the reference mpeg audio decoder fails
>>> * some hardware mp2/vcd/... decoder failing
>>> not solid are
>>> * mplex
>>> * file
>>>
>> Well, having id3 tag when writing mp2 files, when stream copy for
>> example, might be annoying, if user wants id3 tag he can use .mp3 and
>> -acodec mp2.
> 
> hmm indeed, i agree
> feel free to apply the patch to svn (dont forget the regression tests though)
> 

Applied. Regression tests did not need to be updated here, it seems
weird, my tree might be damaged.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312