[FFmpeg-devel] [PATCH] make sure blending the subtitle does not write outside buffer

[Reimar Döffinger]

Hello,
On Sun, Aug 05, 2007 at 01:34:46PM +0200, Michael Niedermayer wrote:
[...]
> neither, you need to know these details and place the subs according to
> how they are supposed to be placed
> if you really lack all this details then how does a binary player display
> it properly?

Sorry, I was sidetracked thinking about the general case, e.g. when
using extracted/separate subtitles. For XSUB in AVI there is of course a
proper solution.
The best practical reasoning I have to offer is that ffplay is mostly
used for development and it makes things somewhat easier if there is one
reason less why the subtitle doesn't appear.
In that light, do you think it would be a good/acceptable idea to make
ffplay display subtitles by default? Because currently to show any in
the sample I need to press 't' to enable them and then seek to the very
beginning, and even then sometimes not all are show, because the data is
in the very first packets which are not placed in the subtitle queue
unless playing really from the very start.

Greetings,
Reimar D?ffinger