[FFmpeg-devel] [PATCH] show-banner and show-license as cmdutils.c functions

[Michael Niedermayer]

Hi

On Wed, Aug 08, 2007 at 10:57:29AM +0200, Stefano Sabatini wrote:
> On date Tuesday 2007-08-07 22:34:29 +0200, Michael Niedermayer encoded:
> [...]
> > > Second attempt, regression test passed.
> > > 
> > > Suggested log: implement show_version and show_license as cmdutils.c functions.
> [...]
> > > @@ -3575,9 +3576,9 @@
> > >  
> > >  const OptionDef options[] = {
> > >      /* main options */
> > > -    { "L", 0, {(void*)show_license}, "show license" },
> > > +    { "L", 0, {(void*)opt_show_license}, "show license" },
> > >      { "h", 0, {(void*)show_help}, "show help" },
> > > -    { "version", 0, {(void*)show_version}, "show version" },
> > > +    { "version", 0, {(void*)opt_show_version}, "show version" },
> > >      { "formats", 0, {(void*)show_formats}, "show available formats, codecs, protocols, ..." },
> > 
> > these changes do NOT belong in this patch, they are not needed for
> > moving the code to cmdutils
> 
> No they belong to this patch, since I defined the symbols show_version
> and show_license in cmdutils.o, so I can't use them for handling the
> -license and -version options. 

A requires B
B does not belong in this patch
from that it follows that
A does not belong in this patch

A= "using show_license, ... as global identifers in cmdutils.c even though
they are already used for a different purpose in ffmpeg.c"


> Anyway it's also better to prefix
> opt_show_version and opt_show_license with "opt", to highlight that
> they're option handler functions (and for consistency with the
> prelevant use in ffmpeg.c).

renaming option parsing functions so that they all have a opt_ prefix is
something seperate, it may or may not be a good idea. but it does not
belong in this patch. furthermore this patch just renames a random subset
of these functions any such change should rename all


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070808/146ffa90/attachment.pgp>