[FFmpeg-devel] [PATCH] fix post r9988 Cygwin builds
Måns Rullgård
mans
Sat Aug 11 20:56:09 CEST 2007
Ramiro Polla <ramiro at lisha.ufsc.br> writes:
> M?ns Rullg?rd wrote:
>> Ramiro Polla <ramiro at lisha.ufsc.br> writes:
>>> Two patches attached.
>>>
>>> Ramiro Polla
>>> Index: configure
>>> ===================================================================
>>> --- configure (revision 10072)
>>> +++ configure (working copy)
>>> @@ -1537,7 +1537,7 @@
>>> check_header termios.h
>>> check_header conio.h
>>>
>>> -check_header arpa/inet.h
>>> +check_header arpa/inet.h ||
>>> check_header winsock2.h
>>
>> Why the || ?
>
> This is the fix for Cygwin, which has both arpa/inet.h and winsock2.h.
> It can't use both.
Shouldn't some ifdeffery in the code take care of that?
>>> check_func inet_aton
>>> Index: configure
>>> ===================================================================
>>> --- configure (revision 10072)
>>> +++ configure (working copy)
>>> @@ -766,6 +766,7 @@
>>> libxvid_encoder_deps="libxvid"
>>>
>>> # demuxers / muxers
>>> +network_deps_any="arpa_inet_h winsock2_h"
>>
>> Wrong place.
>
> Indeed, I'll put it in alphabetical order. Is it wrong because it's not
> in alphabetical order, or because of something else?
Placing it in the protocols section a little further down seems more
logical to me.
--
M?ns Rullg?rd
mans at mansr.com
More information about the ffmpeg-devel
mailing list