[FFmpeg-devel] [PATCH] FLV meta injection (similar toFLVTOOLS2but an addon patch for FFMPEG)

[Compn]

On Sun, 12 Aug 2007 11:45:08 +0000, andrew scribed:

>Please find the modified patch conforming to the 8.6 and 8.7 rules. If
>there are still problem could I have a hint of which rule I have
>broken? =) I think I got it all now but perhaps I make mistake, its
>the first opensource project i have submitted to.


thanks for submitting your patch! it is a nice feature but ffmpeg
developers are strict about new patches.


>> > Index: ffmpeg.c
>> > ===================================================================
>> > --- ffmpeg.c	(revision 10065)
>> > +++ ffmpeg.c	(working copy)
>> > @@ -33,6 +33,7 @@
>> >  #include "opt.h"
>> >  #include "fifo.h"
>> >  #include "avstring.h"
>> > +#include "flvenc.c"
>> 
>> are you serious?


michael is saying that ffmpeg.c should not include flvenc.c 
figure out how the other options are in the code base and
follow that.


>> [...]
>> > @@ -42,6 +42,13 @@
>> >  
>> >  #define AMF_END_OF_OBJECT         0x09
>> >  
>> > +#define NUM_OF_ENTRIES 20
>> > +
>> > +#define AMF_CHILDNODE       3
>> > +#define AMF_CHILDNODEVALUE  10
>> > +#define AMF_PARENTNODE      9
>> > +
>> 
>> these belong in the enum where the other AMF types are

michael means to put these under line 96 of libavformat/flv.h
in that enum with the other AMF types.

-compn