[FFmpeg-devel] Stack variables alignment check in libavcodec/dsputil.c

[Ramiro Ribeiro Polla]

Michael Niedermayer wrote:
> Hi
>
> On Sun, Aug 12, 2007 at 02:39:36PM -0300, Ramiro Polla wrote:
> [...]
>   
>>>   
>>>       
>>>>> what effect does it have on object size?
>>>>>
>>>>>         
>>>>>           
>>>> .text:    unpatched patched
>>>> dsputil.o 0004e270 0004e280
>>>> pthread.o 000003c0 000003d0
>>>> utils.o   000029d0 00002a30
>>>>     
>>>>         
>>> 128 bytes difference
>>>
>>> please add the realignment unconditionally! 128 bytes arent worth the
>>> time users might end up spending due to some random crash (as well as the
>>> number of bugreports we might get) and as someone else already said the 
>>> ABI does not gurantee 16byte alignment so the realignment is needed
>>>
>>>   
>>>       
>> Ok. Attached patch sets it unconditionally for every platform and OS. 
>> Should we make a list in configure only for the platforms that need it, or 
>> is this ok?
>> Patch also adds avcodec_open, which I missed yesterday, and a note in 
>> ff_check_alignment.
>>     
>
> ok
>
>   

Applied.