[FFmpeg-devel] [PATCH] check validity of --list-* parameter

[Aurelien Jacobs]

On Mon, 20 Aug 2007 10:45:21 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> On Mon, Aug 20, 2007 at 12:54:38AM +0100, M?ns Rullg?rd wrote:
> > Aurelien Jacobs <aurel at gnuage.org> writes:
> > 
> > > Attached patch ensure that configure will reject parameters such as
> > > --list-have or --list-foobar. It fixes issue72.
> > > Note that COMPONENT_LIST and is_in can be used to simplify other
> > > part of configure (I will probably propose some patches after this
> > > one is applied).
> > >
> > > --- configure	(r??vision 10131)
> > > +++ configure	(copie de travail)
> > > @@ -291,6 +291,15 @@
> > >  
> > > +is_in(){
> > > +    value=$1
> > > +    shift
> > > +    for var in $*; do
> > > +        [ $var = $value ] && return 0
> > > +    done
> > > +    return 1
> > > +}
> > > +
> > >  check_deps(){
> > >      for cfg; do
> > >          enabled ${cfg}_checking && die "Circular dependency for $cfg."
> > > @@ -567,18 +576,25 @@
> > >  
> > > -CONFIG_LIST='
> > > +COMPONENT_LIST="
> > > +    bsfs
> > > +    decoders
> > > +    demuxers
> > > +    encoders
> > > +    muxers
> > > +    parsers
> > > +    protocols
> > > +"
> > 
> > I don't think COMPONENT is a very good name for this list.
> > 
> > Other than that, I have no comments.
> 
> Same sentiment here, but I don't have a good suggestion for a
> replacement right now.

I agree, but unfortunatly I wasn't able to come up with a better name.
So I applied as is.
If you can think of a better name, don't hesitate to change it in svn.

Aurel