[FFmpeg-devel] [PATCH] configure - simplify grab device selection

[Måns Rullgård]

Ramiro Ribeiro Polla <ramiro at lisha.ufsc.br> writes:

> Diego Biurrun wrote:
>> On Tue, Aug 07, 2007 at 12:33:06AM -0300, Ramiro Ribeiro Polla wrote:
>>
>>> Attached patches simplify configure by treating grab devices like
>>> normal demuxers. They have a proper check in configure.
>>>
>>
>> Hmm, what about dc1394 and dv1394?
>>
>>
>
> Since it is a lib, I think it's better to treat it as a lib like we do
> for all others. Patch attached. I'll apply it in a couple of days if
> there are no objections.
>
> Do you think it would be best to start separating grab devices too? By
> prefixing them all with "grab" or something.
>
> Ramiro Polla
>
> PS: I hope I got alphabetical order correct this time =)

Sorry, but you did not.

> @@ -592,7 +592,7 @@
>      avisynth
>      beos_netserver
>      bktr
> -    dc1394
> +    libdc1394
>      ffmpeg
>      ffplay
>      ffserver
> @@ -780,7 +780,7 @@
>  ac3_demuxer_deps="ac3_parser"
>  audio_demuxer_deps_any="audio_oss audio_beos"
>  audio_muxer_deps_any="audio_oss audio_beos"
> -dc1394_demuxer_deps="dc1394"
> +libdc1394_demuxer_deps="libdc1394"
>  dv1394_demuxer_deps="dv1394"
>  libnut_demuxer_deps="libnut"
>  libnut_muxer_deps="libnut"

These two look rather out of alphabetical order.  AFAIK Portuguese
uses the same collation sequence as English.

> @@ -1584,7 +1584,7 @@
>  enabled libnut     && require libnut libnut.h nut_demuxer_init -lnut
>  enabled libx264    && require x264 x264.h x264_encoder_open -lx264
>  enabled libxvid    && require Xvid xvid.h xvid_global -lxvidcore
> -enabled dc1394     && require libdc1394 libdc1394/dc1394_control.h dc1394_create_handle -ldc1394_control -lraw1394
> +enabled libdc1394  && require libdc1394 libdc1394/dc1394_control.h dc1394_create_handle -ldc1394_control -lraw1394
>  enabled mlib       && require mediaLib mlib_types.h mlib_VectorSub_S16_U8_Mod -lmlib
>  enabled libfaac    && require2 libfaac "stdint.h faac.h" faacEncGetVersion -lfaac
>  enabled libfaad    && require2 libfaad faad.h faacDecOpen -lfaad
> @@ -1795,7 +1795,7 @@
>  enabled libogg    && append pkg_requires "ogg >= 1.1"
>  enabled libtheora && append pkg_requires "theora"
>  enabled libvorbis && append pkg_requires "vorbis vorbisenc"
> -enabled dc1394    && append pkg_requires "libraw1394"
> +enabled libdc1394 && append pkg_requires "libraw1394"
>  
>  echo "install prefix            $PREFIX"
>  echo "source path               $source_path"

These were already out of order, so I'll cut you some slack here.

Wouldn't the Makefile also need an update?

-- 
M?ns Rullg?rd
mans at mansr.com