[FFmpeg-devel] [PATCH] Don't let ctx->skip_frame>0produceerrors

[Carl Eugen Hoyos]

Hi!

On 2007-08-30 13:45, Michael Niedermayer wrote:
> > Index: libavcodec/h264.c
> > ===================================================================
> > --- libavcodec/h264.c    (Revision 10260)
> > +++ libavcodec/h264.c    (Arbeitskopie)
> > @@ -7968,6 +7968,7 @@
> >          return -1;
> >  
> >      if(!(s->flags2 & CODEC_FLAG2_CHUNKS) && !s->current_picture_ptr){
> > + if (avctx->skip_frame>0) return 0;
> > av_log(avctx, AV_LOG_ERROR, "no frame!\n");
> > return -1;
> > }
> 
> well but what if
> avctx->skip_frame>0
> and this code is reached for a reason different then skip_frame ?

Then the user silenced an error by disabling complete decoding.
Or is there a better solution? More different return values for
decode_nal_units() only make the code messier, don't you think?

Carl Eugen