[FFmpeg-devel] [PATCH] h264 bitstream filter

[Benoit Fouet]

Baptiste Coudurier wrote:
> Hi
>
> Benoit Fouet wrote:
>   
>> it's always easier after some sleep :)
>> here it is, along with other modifications i thought of...
>>     
>
> In addition to Mans's comments,
>
>   
>> [...] 
>>
>> +
>> +    else {
>> +        AVCBSFContext *ctx = bsfc->priv_data;
>> +        uint8_t unit_type = buf[4] & 0x1f;
>>     
>
> This is not always correct, since size field length of NAL units in ISO
> Media is specified in extradata (avcC) and not always 4.
>
>   

very true, i'll fix it

> I did not really read after but are you really overwriting NAL size
> field with the startcode ?
>
>   

yes, but i will do it in a slightly different way when i retrieve length
correctly

-- 
Ben
Purple Labs S.A.
www.purplelabs.com