[FFmpeg-devel] [FFmpeg-cvslog] r11100 - in trunk/libavcodec/i386: cavsdsp_mmx.c dsputil_mmx.c dsputil_mmx.h h264dsp_mmx.c mpegvideo_mmx.c vc1dsp_mmx.c

[Rich Felker]

On Fri, Nov 30, 2007 at 12:26:08PM +0100, Michael Niedermayer wrote:
> > (1) static (like it was before)
> > (2) #pragma GCC visibility ...
> > (3) ld -Bsymbolic
> > (4) ld --version-script ...
> > (5) implement full PIC access (double deference, not just rip-relative).
> > 
> > (2) obvisouly requires gcc. (3) and (4) require GNU ld. (5) makes the 
> > shared library slower (I have no idea how much).
> 
> id accept a patch with (3) as well as (1) and reject (5) dunno about the
> others
> 
> also i suspect (3) could lead to some speedups for shared libs ...

Keep in mind that any use of strange linker options must be
accompanied by _detection_ of their availability in configure.
Assuming "os==linux => using foo is ok" is NOT valid.

Rich