[FFmpeg-devel] [PATCH 01/N] RV30/40 Decoder - Core

[Diego Biurrun]

On Sat, Dec 01, 2007 at 08:03:23PM +0200, Kostya wrote:
> $subj

> /**
>  * @file rv34.h
>  * RV30 and RV40 decoder common data declarations.

useless period

> /**
>  * VLC tables used by decoder

the decoder

>     int luma_vlc;            ///< which VLC set will be used for luma blocks decoding
>     int chroma_vlc;          ///< which VLC set will be used for chroma blocks decoding

either "luma/chroma block decoding" or "decoding of luma/chroma blocks"


> int ff_rv34_decode_end(AVCodecContext *avctx);
> /** @} */
> #endif /* FFMPEG_RV34_H */

Stray Doxygen comment?  Also please leave an empty line before the
#endif.

> /**
>  * @file rv34.c
>  * RV30/40 decoder common data.

useless period

> /**
>  * RealVideo 3.0/4.0 inverse transform - special version
>  *
>  * Code is almost the same but final coefficients are multiplied by 1.5
>  * and have no rounding.

The code is almost the same as what?

> /**
>  * Get one coefficient value from bistream and store it.

the bitstream

> /**
>  * Decode starting slice position.
>  * @todo maybe replace with ff_h263_decode_mba() ?

Capitalize.

Diego