[FFmpeg-devel] [PATCH] Fix segfault when decoding corrupt mov (issue 285)

[Baptiste Coudurier]

Hi

Panagiotis Issaris wrote:
> Hi,
> 
> The attached patch fixes a segfault when decoding a corrupt mov file.
> The crash occurred because an error code was being ignored.
> 
> With friendly regards,
> Takis

------------------------------------------------------------------------

Index: libavformat/mov.c
===================================================================
--- libavformat/mov.c	(revision 11160)
+++ libavformat/mov.c	(working copy)
@@ -353,7 +353,7 @@
     c->found_moov=1;
     if(c->found_mdat)
         return 1; /* found both, just go */
-    return 0; /* now go for mdat */
+    return err; /* now go for mdat */
 }

If err is not 0, return err instead of 1 even if found_mdat.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312