[FFmpeg-devel] flac_compute_autocorr_sse2 not pic-safe

[Luca Barbato]

Michael Niedermayer wrote:
> On Tue, Dec 04, 2007 at 03:27:18PM +0100, Edward Hervey wrote:
>> Hi all,
>>
>>   While compiling ffmpeg as static library to be put into a shared
>> library (./configure --enable-static --disable-shared
>> --extra-cflags=-fPIC), I encountered a piece of asm code which isn't
>> PIC-safe.
>>
>>   The proposed patch disables that optimized routine when the
>> configuration doesn't allow it (HAVE_7REGS set to 1).
> 
> patch rejected, this code does not need 7 registers

 :"+&r"(i), "=m"(autoc[j]), "=m"(autoc[j+1]), "=m"(autoc[j+2])
 :"r"(data1+len), "r"(data1+len-j), "m"(*ff_pd_1)

gcc being overzealous?
what about marking this a BROKEN_RELOCATIONS ?

lu

-- 

Luca Barbato

Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero