[FFmpeg-devel] [PATCH] Add 4x4 IDCT

[Michael Niedermayer]

On Sat, Dec 08, 2007 at 02:45:20PM +0200, Kostya wrote:
> On Sat, Dec 08, 2007 at 11:13:19AM +0000, M?ns Rullg?rd wrote:
> > Kostya <kostya.shishkov at gmail.com> writes:
> > 
> > > Here's a patch that adds missing 4x4 IDCT (will be used by VC-1 decoder).
> > >
> > > Index: simple_idct.c
> > > ===================================================================
> > > --- simple_idct.c	(revision 11185)
> > > +++ simple_idct.c	(working copy)
> > > @@ -585,3 +585,17 @@
> > >      }
> > >  }
> > >
> > > +void simple_idct44_add(uint8_t *dest, int line_size, DCTELEM *block)
> > 
> > We should prefix all new non-API functions with ff_, even if it is
> > inconsistent with the rest of the file.
> > 
> > > +{
> > > +    int i;
> > > +
> > > +    /* IDCT4 on each line */
> > > +    for(i=0; i<4; i++) {
> > > +        idct4row(block + i*8);
> > > +    }
> > > +
> > > +    /* IDCT8 and store */
> > 
> > That comment is wrong.
> > 
> > > +    for(i=0; i<4; i++){
> > > +        idct4col_add(dest + i, line_size, block + i);
> > > +    }
> > > +}
> > > Index: simple_idct.h
> > > ===================================================================
> > > --- simple_idct.h	(revision 11125)
> > > +++ simple_idct.h	(working copy)
> > > @@ -42,5 +42,6 @@
> > >
> > >  void simple_idct84_add(uint8_t *dest, int line_size, DCTELEM *block);
> > >  void simple_idct48_add(uint8_t *dest, int line_size, DCTELEM *block);
> > > +void simple_idct44_add(uint8_t *dest, int line_size, DCTELEM *block);
> > >
> > >  #endif /* FFMPEG_SIMPLE_IDCT_H */
> > 
> > Apart from the above, I can see nothing wrong with this, but do wait
> > for an OK from Michael before committing.
> 
> Here's a new patch and thank you for review.

looks ok


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Thouse who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071208/682ec27e/attachment.pgp>