[FFmpeg-devel] [RFC] cryptokey options

[Michael Niedermayer]

On Thu, Dec 13, 2007 at 12:14:20PM +0100, Reimar D?ffinger wrote:
[...]
> > [...]
> > > @@ -67,6 +68,7 @@
> > >  #define AV_OPT_FLAG_SUBTITLE_PARAM  32
> > >  //FIXME think about enc-audio, ... style flags
> > >      const char *unit;
> > > +    int offset2;
> > >  } AVOption;
> > 
> > actually, this is unneeded
> > offset + sizeof(void*) should do
> 
> Changed, though I do not like such implicit "assumptions" too much.

hmm, maybe add a comment to the FF_OPT_TYPE_BINARY enum then to make it more
clear that this is a requirement

ill review the rest of the patch later

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071213/d4e649ad/attachment.pgp>