[FFmpeg-devel] Make ffmpeg.c and ffplay.c use avctx->request_channels

Justin Ruggles justinruggles
Fri Dec 14 22:44:35 CET 2007


Andreas ?man wrote:
> Hello,
> 
> Michael Niedermayer wrote:
>> it is just advisory (=many codecs ignore it currently)
>> codecs which fail hard due to request_chan could be changed ...
> 
> Here are four patches.
> 
> I believe they should be applied at the same time (not in the same
> commit though).
> 
> I've fixed the dca.c and ac3dec.c to interpret reqeust_channels
> in a advisory way.
> 
> ffmpeg.c now sets up the resampler after the first frame is decoded.
> 
> and the changes to ffplay.c is pretty straight forward.
> I have not been able to make SDL work with more than two channels.
> Also, the man-page says that only mono and stereo is supported.
> 
> So, If each maintainer can have a look at these please :)

> Index: libavcodec/ac3dec.c
> ===================================================================
> --- libavcodec/ac3dec.c	(revision 11202)
> +++ libavcodec/ac3dec.c	(working copy)
> @@ -1128,23 +1128,12 @@
>  
> [...]

Looks good to me.

-Justin






More information about the ffmpeg-devel mailing list