[FFmpeg-devel] [RFC] cryptokey options

[Michael Niedermayer]

On Mon, Dec 17, 2007 at 06:46:23PM +0100, Reimar D?ffinger wrote:
> Hello,
> On Fri, Dec 14, 2007 at 12:49:34AM +0100, Michael Niedermayer wrote:
> 
> > patch is probably ok
> 
> Applied with an extra comment.
> 
> > am not really happy about the av_malloc() dependancy but i guess its
> > hard to avoid
> 
> I see no way except limiting the length in general or for the cryptokey
> doing the string -> key conversion in the demuxer.

> The later probably would not really be bad,

i think so as well and would approve a patch which would change it to that :)


> but like this it could e.g. be
> used to quickly hack up a way to set extradata by hand or similar things
> (at least I hope it would).

yes besides the memleaks and double free() this might cause ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071217/77965e6d/attachment.pgp>