[FFmpeg-devel] PATCH: h264 cleanup transpose requirement code

[Marc Hoffman]

On Dec 17, 2007 3:29 PM, Loren Merritt <lorenm at u.washington.edu> wrote:

> On Mon, 17 Dec 2007, Marc Hoffman wrote:
> > On Dec 17, 2007 1:26 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> On Mon, Dec 17, 2007 at 01:10:46PM -0500, Marc Hoffman wrote:
> >>
> >> use idct_permutation_type
> >
> > Thanks thats much better.
>
> dsp.idct_permutation_type describes dsp.idct*, not dsp.h264_idct*
> It happens to work because the default mmx idct is permuted and your
> patch ignores the fact that the permutation isn't FF_TRANSPOSE_IDCT_PERM.
> But your patch will break if the user requests an idct that isn't
> permuted. Now, one can say that it's natural for h264 to break if you
> request a nonstandard idct (even if it previously ignored such a request),
> but FF_IDCT_H264 is one of the settings that breaks.
>

Does this mean the original patch was better?