[FFmpeg-devel] [PATCH] truth value assignment warnings

[Michel Bardiaux]

Diego Biurrun a ?crit :
> On Mon, Dec 17, 2007 at 12:04:33AM +0100, Diego Biurrun wrote:
>> This fixes a couple of "suggest parentheses around assignment used as
>> truth value" warnings.  OK to apply?
> 
> Path updated for latest changes, will apply on Friday if nobody objects.
> 
> Diego

Please dont do this one:

Index: libavcodec/wmaenc.c
===================================================================
--- libavcodec/wmaenc.c	(revision 11264)
+++ libavcodec/wmaenc.c	(working copy)
@@ -178,7 +178,7 @@
      }

      for(ch = 0; ch < s->nb_channels; ch++) {
-        if (s->channel_coded[ch]= 1) { //FIXME only set channel_coded 
when needed, instead of always
+        if ((s->channel_coded[ch]= 1)) { //FIXME only set channel_coded 
when needed, instead of always
              init_exp(s, ch, fixed_exp);

The warning is valid here, since the proper way is to fix the FIXME.

-- 
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/