[FFmpeg-devel] [PATCH] rtsp - alternate protocol

[Aurelien Jacobs]

On Fri, 28 Dec 2007 16:23:45 -0500
"Ronald S. Bultje" <rsbultje at gmail.com> wrote:

> Hi,
> 
> On Dec 28, 2007 3:53 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > On Fri, Dec 28, 2007 at 02:57:08PM -0500, Ronald S. Bultje wrote:
> > > On Dec 28, 2007 2:42 PM, Aurelien Jacobs <aurel at gnuage.org> wrote:
> > > > Either an #ifdef VERSION or a version bump. I personaly don't care.
> > >
> > > No need yet for a version bump, this stuff will go away by itself... New
> > > version of patch#3 attached.
> >
> > patch ok
> 
> 
> Here's a re-post of all three then, just to make it easier to apply.
> 
> [...]
> 
> Index: ffmpeg/libavformat/rtsp.h
> ===================================================================
> --- ffmpeg.orig/libavformat/rtsp.h	2007-12-28 13:30:50.000000000 -0500
> +++ ffmpeg/libavformat/rtsp.h	2007-12-28 13:33:11.000000000 -0500
> @@ -29,6 +29,7 @@
>      RTSP_PROTOCOL_RTP_UDP = 0,
>      RTSP_PROTOCOL_RTP_TCP = 1,
>      RTSP_PROTOCOL_RTP_UDP_MULTICAST = 2,
> +    RTSP_PROTOCOL_RTP_LAST = 3
>  };

You still specify an explicit value for RTP_LAST, which is bad IMO.
Have you read my previous comments about this ?

Aurel