[FFmpeg-devel] [PATCH] rtsp - alternate protocol

[Michael Niedermayer]

On Sat, Dec 29, 2007 at 04:15:34AM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Dec 28, 2007 5:12 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > > @@ -978,6 +998,11 @@
> > >                   "Transport: %s\r\n",
> > >                   rtsp_st->control_url, transport);
> > >          rtsp_send_cmd(s, cmd, reply, NULL);
> > > +        if (reply->status_code == 461 /* Unsupported protocol */ && i
> > == 0 &&
> > > +            num_bits_set(protocol_mask) >= 2) {
> > > +            protocol_mask = unset_lowest_bit(protocol_mask);
> >
> > > +            j = RTSP_RTP_PORT_MIN; i--; continue;
> >
> > NO, try to write clean code, please!
> > or it will take till 2009 to get this into commitable shape
> 
> 
> Well, for what looks easy to implement to me (= small patches), it's either
> a goto (which people disliked) or this. Are there other ways to do this?

what i meant was:

j = RTSP_RTP_PORT_MIN;
i--; 
continue;

instead of
j = RTSP_RTP_PORT_MIN; i--; continue;

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I wish the Xiph folks would stop pretending they've got something they
do not.  Somehow I fear this will remain a wish. -- M?ns Rullg?rd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071229/5e939d14/attachment.pgp>