[Ffmpeg-devel] [PATCH] updated LGPL AC-3 decoder

[Michael Niedermayer]

Hi

On Sat, Feb 10, 2007 at 10:57:39AM -0500, Justin Ruggles wrote:
> Michael Niedermayer wrote:
> > Hi
> > 
> > On Sat, Feb 10, 2007 at 01:02:20AM -0500, Justin Ruggles wrote:
> > 
> >>Hello,
> >>
> >>Here is what I have so far in my attempts to merge the AC-3 decoder
> >>written by Kartikey Mahendra BHATT for the Google Summer of Code.  There
> >>are some things which still need work, and I have some enhancements
> >>planned for after it's included.  Right now, this gives generally
> >>working results, but has some issues.
> >>
> >>The 256-point MDCT is not working correctly.  I'm still trying to get
> >>that fixed.  Also, the downmixing seems to not always work like it
> >>should.  The code could use some clean-up as well.
> >>
> >>The patch I've attached is against current SVN.  The ac3.c and
> >>ac3_decoder.c files go into libavcodec.  When it's committed, ac3.c will
> >>be created by doing an svn copy of ac3enc.c and then patching it to what
> >>I've included here.  I think I got the build system stuff right, but I'm
> >>not completely sure.
> > 
> > 
> > you should have diffed ac3.c against ac3enc.c then, also keep in mind
> > that code duplication (i dont know if theres any after the copy and patch) is
> > unacceptable
> > 
> 
> Thanks for the review.  I was trying to change as little code in the
> decoder as possible since I'm not the original author, but I'll go ahead
> and delve into it more to clean it up and add your suggestions.
> 
> I'll also look closer for any code duplication I may have missed.  As
> far as your suggested changes to the bit allocation, I have many changes
> ready for that as well, but thought it would be simpler to just leave it
> as-is first with svn copy and improve it after.  That said, I'll go
> ahead and post my suggested changes all at once, knowing it's understood
> that it will be multiple commits.

iam not opposed to having the decoder commited to svn and then cleaned up
afterwards if you prefer ... (as long as nothing breaks and as long as the
code does get cleaned up instead of just rotting after commit ...)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070210/09028add/attachment.pgp>